-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added typings for dynamic array of uniform selectors #315
Conversation
1 similar comment
👍 |
Can anyone re-trigger the travis build? The first one failed with an issue not related to this change. What else this PR is missing to proceed? |
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 15 15
=====================================
Hits 15 15 Continue to review full report at Codecov.
|
Hey @sergey-su, sorry to be so late to this. I just merged another long-outstanding typings pr and seem to have introduced some merge conflicts with this pr. If you resolve them and we can find someone to review (I don't use typescript), then I'll get this merged too. |
ba61be7
to
36f256b
Compare
@ellbee , PR branch rebased |
I was hoping for someone who uses Typescript to approve it, but I see @aikoven approved it before the rebase so I'll merge. |
@ellbee Thanks! When are you planning a release that includes this fix? |
I'll likely release a beta sometime over the weekend. There is another TypeScript related issue that I'd like to see if we can clear up (#340) as part of v4 as I don't feel comfortable making TypeScript changes in minor versions. I don't use TypeScript personally so any help would be much appreciated! |
Currently array version of
createSelector
typing has fixed number of selectors known at compile-time. HowevercreateSelector
's implementation supports any number of selectors determined at run-time. Technically input selectors can have different return types. That's impossible to describe in TypeScript. But it's possible to describe the case when all selectors have same return type. For example when input selectors are generated for each element of a container that has nr of elements fixed during selector's lifetime: