Include 4.6 in the TS test matrix #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 105 105
Branches 24 24
=========================================
Hits 105 105 |
|
@markerikson I added this to test 4.6 and also test if the CI finds any issues with master.. and it again looks good to me |
|
Thanks! |
silasbw
referenced
this pull request
in valora-inc/wallet
Jan 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [reselect](https://github.com/reduxjs/reselect) | [`^4.0.0` -> `^4.1.7`](https://renovatebot.com/diffs/npm/reselect/4.1.6/4.1.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/reselect</summary> ### [`v4.1.7`](https://github.com/reduxjs/reselect/releases/tag/v4.1.7) [Compare Source](https://github.com/reduxjs/reselect/compare/v4.1.6...v4.1.7) This release updates the TS types to work correctly with TS 4.9, which made a change that broke the existing `MergeParameters` type implementation. Happily, the TS team [provided a better (and simpler!) `MergeParameters` implementation](https://github.com/microsoft/TypeScript/pull/50831#issuecomment-1253830522). Since that only works with TS 4.7+, we've reworked the internals to handle providing the old implementation to TS 4.2..4.6, and the new implementation to TS 4.7 and greater. As a user, there should be no visible change - just update to 4.1.7. #### What's Changed - Include 4.6 in the TS test matrix by [@​lukeapage](https://github.com/lukeapage) in [https://github.com/reduxjs/reselect/pull/576](https://github.com/reduxjs/reselect/pull/576) - TS 4.9 compat by [@​markerikson](https://github.com/markerikson) in [https://github.com/reduxjs/reselect/pull/587](https://github.com/reduxjs/reselect/pull/587) **Full Changelog**: reduxjs/reselect@v4.1.6...v4.1.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NS4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTUuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kathaypacific
referenced
this pull request
in valora-inc/wallet
Jan 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [reselect](https://github.com/reduxjs/reselect) | [`^4.0.0` -> `^4.1.7`](https://renovatebot.com/diffs/npm/reselect/4.1.6/4.1.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/reselect</summary> ### [`v4.1.7`](https://github.com/reduxjs/reselect/releases/tag/v4.1.7) [Compare Source](https://github.com/reduxjs/reselect/compare/v4.1.6...v4.1.7) This release updates the TS types to work correctly with TS 4.9, which made a change that broke the existing `MergeParameters` type implementation. Happily, the TS team [provided a better (and simpler!) `MergeParameters` implementation](https://github.com/microsoft/TypeScript/pull/50831#issuecomment-1253830522). Since that only works with TS 4.7+, we've reworked the internals to handle providing the old implementation to TS 4.2..4.6, and the new implementation to TS 4.7 and greater. As a user, there should be no visible change - just update to 4.1.7. #### What's Changed - Include 4.6 in the TS test matrix by [@​lukeapage](https://github.com/lukeapage) in [https://github.com/reduxjs/reselect/pull/576](https://github.com/reduxjs/reselect/pull/576) - TS 4.9 compat by [@​markerikson](https://github.com/markerikson) in [https://github.com/reduxjs/reselect/pull/587](https://github.com/reduxjs/reselect/pull/587) **Full Changelog**: reduxjs/reselect@v4.1.6...v4.1.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NS4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTUuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.