V5 final type changes #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fda51ea:
|
- Add `@typescript/analyze-trace` to "devDependencies" to help measure TS performance. - Update `.gitignore` file to exclude the trace folder.
- These two types can now be removed since `Selector` and `OutputSelector` support additional parameters by default.
- Add`dependencyRecomputations` and `resetDependencyRecomputations` to enable debugging input selectors and `argsMemoize`. - Slightly refactor `CreateSelectorOptions` for consistency. - Add more type expansions for better visualization for hover-previews. - Slightly modify `ensureIsArray` utility function. - Rename some of the types related to `MergeParameters` for clarity and future maintainability. - Add JSDocs for types related to `MergeParameters`. - Add `dependencyRecomputations` and `resetDependencyRecomputations` to unit tests. - Add type expansions to `createStructuredSelector` to improve visibility during hover-previews. - Add `DefaultMemoizeFields` with `clearCache` in order to centralize definitions.
- Add more units tests for `createStructuredSelector`. - Update JSDocs for: * `createStructuredSelector` * `defaultEqualityCheck` * `CreateSelectorOptions.memoize` * `CreateSelectorOptions.argsMemoize` * `OutputSelectorFields` * `weakMapMemoize` * `autotrackMemoize`
markerikson
force-pushed
the
v5-final-type-changes
branch
from
d7a97c0
to
fda51ea
Compare
markerikson
reviewed
Nov 21, 2023
src/types.ts
Outdated
|
|
||
| /** | ||
| * Resets the count of {@linkcode OutputSelectorFields.recomputations recomputations} count to 0. | ||
| */ | ||
| resetRecomputations: () => 0 |
There was a problem hiding this comment.
✋ Nitpicking a bit. I know these reset methods do return 0 because of the shorthand logic, but conceptually they really oughta be () => void
There was a problem hiding this comment.
do you think I should change the implementation to
resetRecomputations: () => {
recomputations = 0
}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Major changes:
ParametricSelectorandOutputParametricSelectorsinceSelectorandOutputSelectorsupport additional parameters by default. This is a breaking change!dependencyRecomputationsandresetDependencyRecomputationsto enable debugging input selectors andargsMemoize.Minor changes:
CreateSelectorOptionsfor consistency.ensureIsArrayutility function.MergeParametersfor clarity and future maintainability.MergeParameters.dependencyRecomputationsandresetDependencyRecomputationsto unit tests.createStructuredSelectorto improve visibility during hover-previews.DefaultMemoizeFieldswithclearCachein order to centralize definitions.createStructuredSelector.createStructuredSelectordefaultEqualityCheckCreateSelectorOptions.memoizeCreateSelectorOptions.argsMemoizeOutputSelectorFieldsweakMapMemoizeautotrackMemoize