feat: improve a11y checks

redwoodjs · Feb 25, 2021 · 71993c3 · 71993c3
1 parent f7ac52a
commit 71993c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/config/storybook/main.js b/packages/core/config/storybook/main.js
@@ -10,7 +10,9 @@ module.exports = {
   stories: [
     '../../../../web/src/**/*.stories.{tsx,jsx,js}',
   ],
-  addons: config.web.a11y ? ['@storybook/addon-a11y'] : undefined,
+  // spreading false (like ...false) into an object -> nothing (i.e. {});
+  // great for when we don't wan't to include the property.
+  ...(config.web.a11y && { addons: ['@storybook/addon-a11y'] }),
   webpackFinal: (sbConfig, { configType }) => {
     // configType is 'PRODUCTION' or 'DEVELOPMENT', why shout?
     const isEnvProduction = configType && configType.toLowerCase() === 'production'

diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js
@@ -6,9 +6,8 @@ const config = getConfig()
 module.exports = {
   extends: [
     './shared.js',
-    config.web.a11y ? 'plugin:jsx-a11y/recommended' : undefined,
-  ],
-
+    config.web.a11y && 'plugin:jsx-a11y/recommended',
+  ].filter(Boolean),
   plugins: ['@redwoodjs/eslint-plugin-redwood'],
   overrides: [
     {