Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Canary publishing is failing #2691

Closed
thedavidprice opened this issue Jun 1, 2021 · 2 comments · Fixed by #2693
Closed

CI Canary publishing is failing #2691

thedavidprice opened this issue Jun 1, 2021 · 2 comments · Fixed by #2693
Labels
bug/repro-available A reproduction exists and needs to be confirmed topic/ops-&-contributing-dx

Comments

@thedavidprice
Copy link
Contributor

Starting with #2637, our automated canary publishing has been failing. I don't see anything suspicious in the PR #2637 but would appreciate others taking a look.

The related GH Workflow file is here. And the script it runs is here.

The reason for failing seems to be that Lerna cannot find the most recent version tag. It’s effectively trying to publish null-canary.51 instead of 0.32.3-canary.51:

...
Found 16 packages to publish:
lerna info auto-confirmed 
 - @redwoodjs/api-server => null-canary.58+91537497
 - @redwoodjs/api => null-canary.58+91537497
 - @redwoodjs/auth => null-canary.58+91537497
...
lerna info publish Publishing packages to npm...
lerna ERR! Error: Invalid tag name "^null-canary.58+91537497": Tags may not have any characters that encodeURIComponent encodes.
...

We run this command to fetch tags:

  • git fetch --depth=1 origin +refs/tags/*:refs/tags/*

I tested the command locally and confirmed it's returning "null" (origin is set to the GitHub Framework repo):

redwoodjs-redwood git:(main)$ git fetch --depth=1 origin +refs/tags/*:refs/tags/*
no matches found: +refs/tags/*:refs/tags/*

The git tags do exist, as confirmed with git tag. Not sure how to diagnose further or fix.

@thedavidprice thedavidprice added bug/repro-available A reproduction exists and needs to be confirmed topic/ops-&-contributing-dx v1/priority labels Jun 1, 2021
@thedavidprice
Copy link
Contributor Author

^^ @peterp @dac09

@thedavidprice
Copy link
Contributor Author

ok, this seems to be resolved! (see screenshot below) I had to bump the latest Tag. As long as we correctly use git tag -am to create annotated version tags going forward I believe we are gtg. @peterp please take a look at the related PR and confirm.

Screen Shot 2021-06-01 at 6 04 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/repro-available A reproduction exists and needs to be confirmed topic/ops-&-contributing-dx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant