-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache #2637
Conversation
UPDATE: solved with nhost package update. And, yes, it was an error hidden by yarn.lock I believe. Wow, not at all understanding how I'm encountering this TS build error:
Has it been there all along and we've just missed it due to dependency version resolutions? That's the only thing I've changed in this PR. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@dac09 I believe I've tracked down the Babel error, which is:
It's coming from the transpiled file
The source code is here: redwood/packages/web/src/components/FetchConfigProvider.tsx Lines 15 to 22 in 9d8fa28
So I attempted to use different syntax/conditional here; however, I run into TS errors for Assuming I'm correct, I need your help resolving. Update: I was not correct... |
- Remove depracated authToken from FetchConfigProvider
- FetchConfigProvider tests
…s-ts # By David Price (6) and others # Via GitHub * 'main' of github.com:redwoodjs/redwood: build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656) build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680) bump react types and eslint packages patch version (redwoodjs#2695) build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654) upgrade misc packages with patch (redwoodjs#2694) Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693) Upgrade axios due to security alert. (redwoodjs#2688) add esbuild config to CLI build and dev (redwoodjs#2564) set up yarn offline cache (redwoodjs#2669) Create file watch for type def generation (redwoodjs#2614) Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637) Fix serve tests (redwoodjs#2668) # Conflicts: # packages/cli/src/commands/generate/types/types.js # packages/internal/src/generate/generate-project-typedefs.js # packages/internal/src/generate/helpers.js # packages/internal/src/generate/templates/scenarios.d.ts.template
…ter-tests * 'main' of github.com:redwoodjs/redwood: downgrade jest-watch-typeahead 0.6.3 (redwoodjs#2699) Exclude yarn packages cache. (redwoodjs#2697) build(deps): bump ts-morph from 10.1.0 to 11.0.0 (redwoodjs#2656) build(deps): bump core-js from 3.12.1 to 3.13.1 (redwoodjs#2680) bump react types and eslint packages patch version (redwoodjs#2695) build(deps): bump esbuild from 0.12.1 to 0.12.5 (redwoodjs#2654) upgrade misc packages with patch (redwoodjs#2694) Fix lerna canary publishing; use default --canary versioning with `git describe` (redwoodjs#2693) Upgrade axios due to security alert. (redwoodjs#2688) add esbuild config to CLI build and dev (redwoodjs#2564) set up yarn offline cache (redwoodjs#2669) Create file watch for type def generation (redwoodjs#2614) Pin package dependencies, remove CRWA template yarn.lock, set up Yarn offline cache (redwoodjs#2637) Fix serve tests (redwoodjs#2668) Add script to create a functional test project using the latest CRWA template (redwoodjs#2324) build(deps): bump @typescript-eslint/eslint-plugin from 4.24.0 to 4.25.0 (redwoodjs#2627) Manage history state length exploding if clicking on a link with with the current route location (redwoodjs#2616) [forms] Fix number validation msg (redwoodjs#2552)
Per Core Team discussion, I made the following changes in an attempt to improve dependency stability across packages:
set up Yarn offline cache; add dependency tgz files to repo(moving to separate PR set up yarn offline cache #2669)