Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): fix env var loading in createServer #10021

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Feb 16, 2024

Running the server file via node means RWJS_CWD will never be set so we can't rely on it to load env files. I seemed to have gotten this right for the web server in #9948 but missed it here in the api server.

@jtoar jtoar added the release:fix This PR is a fix label Feb 16, 2024
@jtoar jtoar added this to the v7.0.0 milestone Feb 16, 2024
@jtoar jtoar merged commit 0f158c2 into main Feb 16, 2024
40 checks passed
@jtoar jtoar deleted the ds-server/fix-env-var-loading-in-create-server branch February 16, 2024 01:14
jtoar added a commit that referenced this pull request Feb 16, 2024
Running the server file via node means `RWJS_CWD` will never be set so
we can't rely on it to load env files. I seemed to have gotten this
right for the web server in
#9948 but missed it here in the
api server.
dac09 added a commit to dac09/redwood that referenced this pull request Feb 16, 2024
* 'main' of github.com:redwoodjs/redwood: (22 commits)
  fix: Handle static assets on the `rw-serve-fe` (redwoodjs#10018)
  fix(server): fix env var loading in `createServer` (redwoodjs#10021)
  fix(deps): remove react types packages from `@redwoodjs/testing` dependencies (redwoodjs#10020)
  chore(release): add back `update-package-versions` task (redwoodjs#10017)
  chore(renovate): Disable for experimental apollo package (redwoodjs#10016)
  RSC: server cells lowercase data function (redwoodjs#10015)
  fix(RSC/SSR): pass CLI options through to apiServerHandler (redwoodjs#10012)
  7.0 RC: Remove hardcoded check for `session.id` (redwoodjs#10013)
  Spelling fix in what-is-redwood.md (redwoodjs#10011)
  Typos in realtime.md (redwoodjs#10010)
  RSC: Server cell smoke tests (redwoodjs#10008)
  RSC: test-project EmptyUser 'use client' cell (redwoodjs#10007)
  RSC: babel-plugin-redwood-cell remove redundant reset (redwoodjs#10006)
  chore(deps): Upgrade to yarn v4.1.0 (redwoodjs#10002)
  fix(docs): Spelling of `data-migrate` command (redwoodjs#10003)
  docs: add aliases fo `type-check` command (redwoodjs#10004)
  RSC: Insert 'use client' in scaffolded components (redwoodjs#9998)
  fix(telemetry): Fix 'destroy' spelling (redwoodjs#10000)
  chore(jsdocs): Fix jsdoc formatting for hover help (redwoodjs#9999)
  bug: Update setupHandler.ts firebase version (redwoodjs#9997)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants