Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scenario): Make sure to cleanup even if test fails #10112

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Mar 5, 2024

Fixes #10068

I'm still trying to reproduce the other issue described in #10068 first. Will add a fix for that separately.

@dac09 dac09 added this to the next-release-patch milestone Mar 5, 2024
@dac09 dac09 self-assigned this Mar 5, 2024
@dac09 dac09 added the release:fix This PR is a fix label Mar 5, 2024
@dac09 dac09 requested a review from cannikin March 5, 2024 09:46
@dac09
Copy link
Collaborator Author

dac09 commented Mar 5, 2024

@cannikin would you take a look at this please?

@dac09 dac09 enabled auto-merge (squash) March 6, 2024 06:20
@dac09 dac09 merged commit e9ecbb0 into redwoodjs:main Mar 6, 2024
41 checks passed
@dac09 dac09 deleted the fix/scenario-cleanup-issues-p1 branch March 6, 2024 06:40
dac09 added a commit that referenced this pull request Mar 6, 2024
…support

* 'main' of github.com:redwoodjs/redwood: (30 commits)
  fix(scenario): Make sure to cleanup even if test fails (#10112)
  Update babel monorepo to v7.24.0 (#10090)
  Update storybook monorepo to v7.6.17 (#10089)
  Update dependency @apollo/client to v3.9.5 (#10087)
  fix(serve): Allow periods in most paths (#10114)
  feat(rsc-streaming): Integrating RSC builds with Streaming and Client side hydration (#10031)
  chore(style): getDefaultViteConfig source format (#10111)
  chore(refactor): vite - extract default vite config (#10110)
  chore(comment): cli index FIXME comment about ugly big red box
  RSC: rscBuildAnalyze: Start at web/src/ (#10109)
  RSC: ensureProcessDirWeb() (#10108)
  RSC: Extract webpack shims into their own file (#10107)
  RSC: Remove completed TODO comment
  RSC: Babel react plugin not needed for analyze phase (#10106)
  RSC: runFeServer: wrap RSC code with `if (rscEnabled)` (#10105)
  RSC: Update comments, naming etc based on Danny's input (#10104)
  RSC: Rename to buildRscClientAndServer (#10103)
  RSC: Rename to rscBuildForServer, and tweak some comments (#10102)
  SSR: Extract buildForStreamingServer function (#10099)
  chore(unit-tests): Silence middleware error logging (#10097)
  ...
@jtoar jtoar modified the milestones: next-release-patch, v7.0.7 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Scenarios broken with redwood 7
3 participants