Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redwood.toml to yarn rw info #10518

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 26, 2024

As people start trying more experimental features, like streaming-ssr and RSCs it'll be good to know exactly what redwood.toml settings they have.

This PR includes (a somewhat slimmed down version of) their redwood.toml in the yarn rw info output that we ask everyone to include in their issue reports.
(It would have helped with my misunderstanding of the issue in #10511 and saved @dthyresson from asking about the apiGraphQLUrl in #10470, etc)

Before

  System:
    OS: macOS 14.1.1
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - /usr/local/bin/node
    Yarn: 4.1.1 - /usr/local/bin/yarn
  Databases:
    SQLite: 3.39.5 - /usr/bin/sqlite3
  Browsers:
    Safari: 17.1

After

  System:
    OS: macOS 14.1.1
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - /usr/local/bin/node
    Yarn: 4.1.1 - /usr/local/bin/yarn
  Databases:
    SQLite: 3.39.5 - /usr/bin/sqlite3
  Browsers:
    Safari: 17.1
  redwood.toml:
    [web]
      title = "Redwood App"
      port = 8910
      apiUrl = "/.redwood/functions" # You can customize graphql and dbauth urls individually too: see https://redwoodjs.com/docs/app-configuration-redwood-toml#api-paths
      includeEnvironmentVariables = [
        # Add any ENV vars that should be available to the web side to this array
        # See https://redwoodjs.com/docs/environment-variables#web
      ]
    [api]
      port = 8911
    [browser]
      open = true
    [notifications]
      versionUpdates = ["latest"]

@Tobbe Tobbe added the release:feature This PR introduces a new feature label Apr 26, 2024
@Tobbe Tobbe added this to the next-release milestone Apr 26, 2024
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tobbe Tobbe merged commit 420961c into redwoodjs:main Apr 26, 2024
46 checks passed
@Tobbe Tobbe deleted the tobbe-info-rw-toml branch April 26, 2024 09:34
dac09 added a commit that referenced this pull request Apr 26, 2024
…g-gen-mw-p2

* 'main' of github.com:redwoodjs/redwood:
  RSC: Add RSC+SSR smoke test to CI (#10477)
  fix(dbauth-mw): Use response passed in to middleware (#10516)
  Add redwood.toml to `yarn rw info` (#10518)
  chore(tests): Fix packages/web tests (#10517)
  fix(dbauth-mw): Unset cookie instead of clearing (#10502)
  chore(deps): Upgrade to React canary 20240424 (#10513)
  chore(deps): Upgrade to React Testing Library 14.3.1 (#10514)
  feat(upgrade): Use GitHub token if available when downloading patches (#10515)
Josh-Walker-GM pushed a commit that referenced this pull request Apr 30, 2024
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v7.5.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants