RSC: Silence unsupported-dynamic-import warning #10750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting a bunch of warnings like these
Adding
/* @vite-ignore */
doesn't help, because this is an esbuild warning.There are a lot of issues on the esbuild repo about this warning. evanw/esbuild#1155 is one, and it also lists a whole bunch of others.
Here's an open issue about adding support for comments, like the vite one I've already tried with, for esbuild: evanw/esbuild#1240. When/if that issue gets resolved we should move to using that. For now I'm silencing all "unsupported-dynamic-import" warnings, which isn't ideal, but will have to do for now.
Here's a vite issue about silencing an esbuild warning vitejs/vite#14768, and the answer there is to use
esbuild.logLevel
, which is what I also do in this PR