Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codemods): Remove pre v1 related content #10831

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Code scanning is complaining about having syntax errors in certain old codemod files. It's not a big deal and perhaps we could have fixed whatever it was complaining about but there's no real reason to have this very old - and arguably no longer relevant - code in the repo. For reference v1 was released over 2 years ago. These codemods will continue be available in previously published versions on NPM.

Changes

  1. Removes all codemods intended for versions pre v1.0.0.

Notes
I marked this as next release major just so it's easier to communicate that we dropped these packages as of vX rather than as of vX.Y.Z.

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the next-release-major milestone Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Jun 17, 2024
@Josh-Walker-GM Josh-Walker-GM requested a review from Tobbe June 17, 2024 18:09
@Tobbe
Copy link
Member

Tobbe commented Jun 18, 2024

Good call! Thanks for cleaning things up 🧹

@Josh-Walker-GM Josh-Walker-GM merged commit ad85476 into main Jun 18, 2024
51 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/codemods-remove-pre-v1 branch June 18, 2024 23:49
@Josh-Walker-GM Josh-Walker-GM added release:breaking This PR is a breaking change and removed release:chore This PR is a chore (means nothing for users) labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants