Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI runner Windows cache false positive #1095

Merged
merged 9 commits into from
Sep 5, 2020

Conversation

thedavidprice
Copy link
Contributor

@thedavidprice thedavidprice commented Sep 5, 2020

Attempting three adjustments:

  • runner is still triggering on merge; moved conditional and updated syntax
  • set cache to be conditional to skip Windows
  • attempting a fix to Windows long running yarn install

Cache is still having false positives on Windows, which results in failed CI due to missing packages.

Cache or no cache, the Windows runner takes about 10 min largely due to the warning "There appears to be trouble with your network connection. Retrying..." during yarn install. I'm trying the yarn config registry workaround here: yarnpkg/yarn#5259 (comment)

SUMMARY

  • I was not able to work around the Windows runner "...trouble with network connection..."
  • The runner is now skipping caching for Widows
  • The "is merged PR" conditional wasn't working. I moved position and will check if it correctly skips when merging this PR
    • update: it does not work and still runs on merge... TBD

@thedavidprice
Copy link
Contributor Author

Based on:

I tried the following and still ended up with the "There appears to be trouble with your network connection. Retrying..." 10 min runtime.

      - name: Disable Windows Defender Realtime Monitoring
        if: matrix.os == 'windows-latest'
        run: |
          powershell Start-Process -PassThru -Wait PowerShell -ArgumentList \
            "'-Command Set-MpPreference -DisableArchiveScanning \$true'";
          powershell Start-Process -PassThru -Wait PowerShell -ArgumentList \
            "'-Command Set-MpPreference -DisableBehaviorMonitoring \$true'";
          powershell Start-Process -PassThru -Wait PowerShell -ArgumentList \
            "'-Command Set-MpPreference -DisableRealtimeMonitoring \$true'";

      - name: Set Windows package registry
        if: matrix.os == 'windows-latest'
        run: yarn config set registry "http://registry.npmjs.org"   

@thedavidprice thedavidprice merged commit 445484b into main Sep 5, 2020
@thedavidprice thedavidprice deleted the dsp-ci-runner-windows-cache-issue branch September 5, 2020 03:16
@thedavidprice thedavidprice added this to the Next Release milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant