Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: RSA: Remove unused check for '$$id' #11159

Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Aug 6, 2024

With how our build process works now we don't need this check anymore

@Tobbe Tobbe added the release:fix This PR is a fix label Aug 6, 2024
@Tobbe Tobbe added this to the chore milestone Aug 6, 2024
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Aug 6, 2024
@Tobbe Tobbe merged commit 5dea4a7 into redwoodjs:main Aug 6, 2024
52 of 54 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-rsa-do-not-check-for-dollar-dollar branch August 6, 2024 11:33
dac09 added a commit to dac09/redwood that referenced this pull request Aug 7, 2024
…rw-uploads

* 'feat/rw-uploads' of github.com:dac09/redwood:
  chore(tsconfig.build): Fix type checking for tests etc (redwoodjs#11167)
  chore(config): migrate renovate config (redwoodjs#11157)
  fix(deps): update prisma monorepo to v5.18.0 (redwoodjs#11165)
  chore(fixture): Rebuild test project fixture (redwoodjs#11166)
  chore(ci): Print full diff when check-test-project-fixture fails (redwoodjs#11164)
  chore(rwjs/vite): Rename build script and format source (redwoodjs#11163)
  chore(tsconfig): Format vite tsconfig (redwoodjs#11162)
  RSC: RSA: Better match error handling with how we generally do it in RW (redwoodjs#11161)
  RSC: RSA: Add more comments to the basic 'use server' check (redwoodjs#11160)
  RSC: RSA: Remove unused check for '$$id' (redwoodjs#11159)
  RSC: Fix red squiggles in transform client tests (redwoodjs#11156)
  RSC: Improve type safety in RSC transform plugins (redwoodjs#11155)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants