Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-fixture): correct rebuild script string suffix substitution #11339

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

We replace the randomly generated suffix in scenarios when we rebuild the test fixture to prevent git conflicts. The regex wasn't quite right. The number is randomly generated between 0 and 10 million but the regex required at least 6 digits. There was therefore cases where the generated number was less than 6 digits and did not get replaced.

@Josh-Walker-GM Josh-Walker-GM added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Aug 22, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Aug 22, 2024
@Josh-Walker-GM Josh-Walker-GM self-assigned this Aug 22, 2024
@Josh-Walker-GM Josh-Walker-GM merged commit 5f9ab5b into main Aug 22, 2024
47 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/chore-test-fixture-rebuild-suffix-fix branch August 22, 2024 03:07
dac09 added a commit to dac09/redwood that referenced this pull request Aug 22, 2024
…into feat/rw-uploads-extension

* 'feat/rw-uploads-extension' of github.com:dac09/redwood:
  chore(test-fixture): correct rebuild script string suffix substitution  (redwoodjs#11339)
  refactor(forms): Build with esbuild and add conditional exports (redwoodjs#11338)
  refactor(prerender): build with esbuild and introduce conditional exports (redwoodjs#11337)
  Adds more tests! Refactor rw-jobs-worker  (redwoodjs#11335)
  refactor(auth-providers): switch to esbuild for some 'web' packages (redwoodjs#11334)
  Jobs doc updates (redwoodjs#11333)
  chore(ci): Split formatting check into separate job  (redwoodjs#11332)
  Updates caching doc code snippets to be consistent (redwoodjs#11331)
  chore(tsconfig): Properly link to api-server's tsconfig (redwoodjs#11330)
  Adds background job scheduling and execution (redwoodjs#11238)
  [gh11317] Added documentation for working with Jest and Alias Paths (redwoodjs#11323)
  fix(record): Update dependencies and build dual esm/cjs (redwoodjs#11300)
  chore(build): Consistent tsconfig and buildinfo naming for CJS (redwoodjs#11326)
  chore(test): Fix RSC server cell smoke test (redwoodjs#11327)
  chore(playwright): Make RSC tests less flakey (redwoodjs#11325)
  chore(ci): Temporary fix for format checking on all PRs (redwoodjs#11324)
  chore(build): Move more repetitive code into framework-tools (redwoodjs#11320)
  chore(docs): fix docs formatting (redwoodjs#11321)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant