Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook): Remove consideration of mjs from docgen plugin #11346

Merged
merged 4 commits into from
Aug 23, 2024
Merged

feat(storybook): Remove consideration of mjs from docgen plugin #11346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d527cda
Remove mjs from docgen
arimendelow Aug 22, 2024
f5ef4ca
Merge branch 'main' into ari/remove-mjs-docgen
arimendelow Aug 22, 2024
fc646cf
remove unnecessary default arguments
Josh-Walker-GM Aug 23, 2024
b430da2
Merge branch 'main' into ari/remove-mjs-docgen
Josh-Walker-GM Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/storybook/src/plugins/react-docgen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type Options = {
}

export function reactDocgen({
include = /\.(mjs|tsx?|jsx?)$/,
include = /\.(tsx?|jsx?)$/,
exclude = [/node_modules\/.*/],
}: Options = {}): PluginOption {
const cwd = process.cwd()
Expand Down
6 changes: 1 addition & 5 deletions packages/storybook/src/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ export const viteFinal: StorybookConfig['viteFinal'] = async (config) => {
const { plugins = [] } = config

// Needs to run before the react plugin, so add to the front
plugins.unshift(
reactDocgen({
include: /\.(mjs|tsx?|jsx?)$/,
}),
)
plugins.unshift(reactDocgen())

return mergeConfig(config, {
// This is necessary as it otherwise just points to the `web` directory,
Expand Down
Loading