chore(rsc): Switch to web streams instead of using node streams #11445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
the
experimental
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 5, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Sep 6, 2024
…ood into feat/storage-additional-tests * 'feat/storage-additional-tests' of github.com:dac09/redwood: chore(deps): update dependency @supabase/supabase-js to v2.45.3 (redwoodjs#11434) chore(deps): update dependency jsdom to v24.1.3 (redwoodjs#11438) chore(deps): update dependency @playwright/test to v1.47.0 (redwoodjs#11433) fix(resolutions): Remove rehackt resolution (redwoodjs#11447) chore(deps): update dependency @types/eslint to v8.56.12 (redwoodjs#11435) chore(deps): update dependency @envelop/core to v5.0.2 (redwoodjs#11432) chore(deps): update eslint monorepo to v9.9.1 (redwoodjs#11441) chore(deps): update actions/upload-artifact digest (redwoodjs#11442) chore(deps): update dependency prettier-plugin-packagejson to v2.5.2 (redwoodjs#11440) chore(deps): update mheap/github-action-required-labels digest to d25134c (redwoodjs#11443) chore(deps): update dependency prettier-plugin-packagejson to v2.5.2 (redwoodjs#11439) chore(deps): update actions/checkout action to v4.1.7 (redwoodjs#11444) Updates SDL codegen to handle prettier 3 correctly (redwoodjs#11446) Updates on how locking a job works chore(rsc): Switch to web streams instead of using node streams (redwoodjs#11445)
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Sep 6, 2024
…ploads-cli * 'main' of github.com:redwoodjs/redwood: (35 commits) docs(uploads): Add upload docs (redwoodjs#11398) chore(storage): Add type tests & extra tests for savers and result extension (redwoodjs#11416) chore(deps): update dependency @supabase/supabase-js to v2.45.3 (redwoodjs#11434) chore(deps): update dependency jsdom to v24.1.3 (redwoodjs#11438) chore(deps): update dependency @playwright/test to v1.47.0 (redwoodjs#11433) fix(resolutions): Remove rehackt resolution (redwoodjs#11447) chore(deps): update dependency @types/eslint to v8.56.12 (redwoodjs#11435) chore(deps): update dependency @envelop/core to v5.0.2 (redwoodjs#11432) chore(deps): update eslint monorepo to v9.9.1 (redwoodjs#11441) chore(deps): update actions/upload-artifact digest (redwoodjs#11442) chore(deps): update dependency prettier-plugin-packagejson to v2.5.2 (redwoodjs#11440) chore(deps): update mheap/github-action-required-labels digest to d25134c (redwoodjs#11443) chore(deps): update dependency prettier-plugin-packagejson to v2.5.2 (redwoodjs#11439) chore(deps): update actions/checkout action to v4.1.7 (redwoodjs#11444) Updates SDL codegen to handle prettier 3 correctly (redwoodjs#11446) Updates on how locking a job works chore(rsc): Switch to web streams instead of using node streams (redwoodjs#11445) chore(deps): update dependency esbuild to v0.23.1 (redwoodjs#11436) chore(rsc): Remove unused methods in the worker (redwoodjs#11431) chore(rsc): Simplify worker by not using vite config (redwoodjs#11430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do this to have the same RSC renderer for both SSR and the worker. SSR already used web streams.
And I chose to change the worker one because we want to move towards using web compatible APIs wherever possible – it's where the ecosystem is moving