Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1278 launch Storybook with path w/ spaces #1495

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

dthyresson
Copy link
Contributor

This PR addresses issue #1278

#1278

Now, the yarn rw storybook command succeeds to:

yarn rw storybook     
yarn run v1.22.10
$ '/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/node_modules/.bin/rw' storybook
$ '/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/node_modules/.bin/start-storybook' --config-dir ../node_modules/@redwoodjs/core/config/storybook --port 7910 --no-version-updates --static-dir '/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/web/public' --ci
$ '/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/node_modules/.bin/msw' init '/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/web/public'
Initializing the Mock Service Worker at "/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/web/public"...

Service Worker successfully created!
/Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/web/public/mockServiceWorker.js

Continue by creating a mocking definition module in your application:

  https://mswjs.io/docs/getting-started/mocks

info @storybook/react v5.3.19
info 
info => Loading static files from: /Users/dthyresson/Dropbox (Personal)/projects/redwoodjs/pectin/web/public .
info => Loading presets
info => Loading presets
info => Loading custom babel config as JS
info => Loading custom babel config as JS
info => Loading config/preview file in "../node_modules/@redwoodjs/core/config/storybook".
info => Adding stories defined in "../node_modules/@redwoodjs/core/config/storybook/main.js".
info => Using default Webpack setup.
info => Using base config because react-scripts is not installed.
webpack built 0241b95ed5395d2508cd in 12507ms
╭───────────────────────────────────────────────────╮
│                                                   │
│   Storybook 5.3.19 started                        │
│   12 s for manager and 14 s for preview           │
│                                                   │
│    Local:            http://localhost:7910/       │
│    On your network:  http://192.168.7.53:7910/    │
│                                                   │

Note: While this succeeds in finding the paths properly, I am getting a memory error:

webpack building...
webpack built d6d6922e94ad11a99e16 in 15683ms
webpack building...
70% building 2/2 modules 0 active
<--- Last few GCs --->

[71095:0x110008000]   183649 ms: Scavenge (reduce) 4031.0 (4100.8) -> 4030.2 (4101.8) MB, 7.0 / 0.0 ms  (average mu = 0.094, current mu = 0.048) allocation failure 
[71095:0x110008000]   183663 ms: Scavenge (reduce) 4031.1 (4100.8) -> 4030.3 (4101.8) MB, 8.6 / 0.0 ms  (average mu = 0.094, current mu = 0.048) allocation failure 
[71095:0x110008000]   183674 ms: Scavenge (reduce) 4031.2 (4100.8) -> 4030.5 (4102.1) MB, 7.0 / 0.0 ms  (average mu = 0.094, current mu = 0.048) allocation failure 


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

But, I think this may be an unrelated and separate issue that I will investigate and report.

@dthyresson
Copy link
Contributor Author

@Tobbe would you be able test this on Windows as well. It is similar to the test and db command issues.

Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦑

@dthyresson dthyresson merged commit a94595a into redwoodjs:main Nov 19, 2020
@thedavidprice thedavidprice added this to the Next release milestone Nov 19, 2020
@dthyresson dthyresson deleted the dt-fix-storybook-path-spaces branch December 23, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error launching Storybook via Redwood CLI in a directory path that includes spaces
3 participants