[ts] POC type expansion for withCell #2222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense, and I think is complementary to #2205. That PR adds static typing for the props that a cell expects, and this PR adds static typing for the data from the cell's GraphQL query. Both seem important! The only potential conflict will be in deciding the proper order of type parameters passed to the cell constructor. |
|
Oh ok, @corbt your comment helped me realize what I was missing from your argument. This POC contains that too though, with only type change, if you look at the typing on the returned function on L120 and L123. I don't think it'd work as it currently stands, but it could, with a little bit more work. |
|
Solved in #2485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not done, but a draft to show an early "typing only" change on the
withCellHOC, reacting to the #2205 issue, demonstrating some of the not-yet utilized typing magic that could be done there. Also making typing resemble code better (as it is currently slightly misleading with the before-after-query-props)