Removes console warnings in webhook verifiers #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 24, 2021
…-codegen * 'main' of github.com:redwoodjs/redwood: Removes console warnings in webhook verifiers (redwoodjs#2563) build(deps): bump eslint from 7.26.0 to 7.27.0 (redwoodjs#2610) CONTRIBUTING.md: styling tweaks for improved readability and consistency (redwoodjs#2608) build(deps): bump esbuild from 0.11.21 to 0.12.1 (redwoodjs#2579) Cache magic.link's token (redwoodjs#2555) build(deps): bump @babel/plugin-transform-runtime from 7.14.2 to 7.14.3 (redwoodjs#2603) build(deps): bump @types/node from 15.3.1 to 15.6.0 (redwoodjs#2601) eslint-plugin-import 2.23.2 with lint fixes (redwoodjs#2604) build(deps): bump @apollo/client from 3.3.18 to 3.3.19 (redwoodjs#2576) build(deps): bump apollo-server-lambda from 2.22.2 to 2.24.1 (redwoodjs#2580) build(deps): bump babel-plugin-graphql-tag from 3.2.0 to 3.3.0 (redwoodjs#2600) build(deps): bump @babel/cli from 7.13.16 to 7.14.3 (redwoodjs#2578) build(deps-dev): bump @types/lodash from 4.14.169 to 4.14.170 (redwoodjs#2597) build(deps-dev): bump @types/findup-sync from 2.0.2 to 4.0.0 (redwoodjs#2574) Aggregate Dependabot misc patch minor upgrades (redwoodjs#2596) CONTRIBUTING.md: add missing char (redwoodjs#2594) changes test command instructions to reference run-e2e instead of test-tutorial (redwoodjs#2593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHA and SecretKey verifiers uses console.warn to say that it would ignore options -- because the methods to sign and verify didn't need any options (unlike JWT or TimestampSchema that can have some).
This warning gets terribly annoying in test and prod and isn't helpful.
This PR reworks those sign and verify methods so those they don't need the options and hence no warnings.