Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release script for patches #4402

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Feb 7, 2022

Partially closes #2067. This PR prepares the release script for releasing patches.

Also, you can now pass options to answer some of the questions from the CLI and speed things up:

yarn release --semver minor --no-prs --checkout

But "check" steps will never be skipped.

@thedavidprice, a couple things:

-> I've seen two syntaxes for checking out the release branch:

# 1
git checkout -b release/patch/v0.28.1 v0.28.0
# 2
git checkout tags/v0.28.0 -b release/patch/v0.28.1

I'm going with the first one because that's what's in the git-tagging docs: https://git-scm.com/book/en/v2/Git-Basics-Tagging (at the end—"Checking out Tags").

-> This script now handles updating next-release-patch pull requests.

-> This one's probably obvious but we probably have to do a run through to get this 100% right.

@jtoar jtoar self-assigned this Feb 7, 2022
@jtoar jtoar changed the title Prepare release script for patch Prepare release script for patches Feb 7, 2022
@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Feb 7, 2022
package.json Outdated Show resolved Hide resolved
@jtoar jtoar force-pushed the ds-prep-release-script-for-patch branch from e23d909 to 341b720 Compare February 7, 2022 14:19
@jtoar jtoar marked this pull request as ready for review February 7, 2022 14:19
@thedavidprice
Copy link
Contributor

@jtoar I didn't quite follow you here:

-> I've seen two syntaxes for checking out the release branch:

1

git branch release/patch/v0.28.1 v0.28.0

2

git checkout tags/v0.28.0 -b release/patch/v0.28.1

I'm going with the first one because that's what's in the git-tagging docs: https://git-scm.com/book/en/v2/Git-Basics-Tagging (at the end—"Checking out Tags").

You are saying we should try git branch ...

Just looked through the docs and saw this, which implies git checkout ... for me:
Screen Shot 2022-02-07 at 8 05 59 AM

I haven't tried git branch ... yet. No preference by me if the results are the same. TBD

@jtoar
Copy link
Contributor Author

jtoar commented Feb 7, 2022

@thedavidprice Sorry, I meant to say checkout instead of branch! Updating the OP now.

Copy link
Contributor

@jtoar Ah, that makes sense! Thanks.

@jtoar
Copy link
Contributor Author

jtoar commented Feb 7, 2022

@thedavidprice merging now before we do a run through 'cause I'm sure we'll have to tweak then.

@jtoar jtoar merged commit e989649 into main Feb 7, 2022
@jtoar jtoar deleted the ds-prep-release-script-for-patch branch February 7, 2022 17:40
@jtoar jtoar added this to the next-release milestone Feb 7, 2022
@jtoar jtoar mentioned this pull request Feb 8, 2022
3 tasks
@thedavidprice thedavidprice modified the milestones: next-release, v0.45.0 Feb 11, 2022
Copy link

@Thompson1985 Thompson1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Leveling up our Patch release process
4 participants