-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release script for patches #4402
Conversation
e23d909
to
341b720
Compare
@jtoar I didn't quite follow you here:
You are saying we should try Just looked through the docs and saw this, which implies I haven't tried |
@thedavidprice Sorry, I meant to say |
@jtoar Ah, that makes sense! Thanks. |
@thedavidprice merging now before we do a run through 'cause I'm sure we'll have to tweak then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Partially closes #2067. This PR prepares the release script for releasing patches.
Also, you can now pass options to answer some of the questions from the CLI and speed things up:
But "check" steps will never be skipped.
@thedavidprice, a couple things:
-> I've seen two syntaxes for checking out the release branch:
I'm going with the first one because that's what's in the git-tagging docs: https://git-scm.com/book/en/v2/Git-Basics-Tagging (at the end—"Checking out Tags").
-> This script now handles updating
next-release-patch
pull requests.-> This one's probably obvious but we probably have to do a run through to get this 100% right.