CLI: Convert helpers and src/lib to ts #557
Conversation
MarkPollmann
changed the title
MarkPollmann
force-pushed
the
convert_helpers_to_ts
branch
from
1cabe7c
to
bd88662
Compare
MarkPollmann
force-pushed
the
convert_helpers_to_ts
branch
from
bd88662
to
0b08663
Compare
|
I typed the cli/src/lib folder as well. There are a few issues left which I didn't know how to type properly. I don't think they are showstoppers but maybe someone else could take a look :) Just a heads-up, I needed to re-order functions in src/lib/index.ts as TS complained that functions were used before they were defined. No idea why eslint complains about import ordering for files I didn't touch, though. 🤔 Edit: ran |
|
I don't think we have an equivalent ordering rule in the JS world. I find it somewhat annoying, but it kinda makes sense. |
|
@MarkPollmann This is an amazing amount of work, thank you so much for this. |
|
Hey @MarkPollmann, I've messed up on this one - I should've merged it ages ago! I'm going to branch off your branch and see what I can in. |
related to Tracking Issue #523
As these are some of the first ts files and I don't know the project well yet it was quite difficult to pin down the exact types. I tried to guess them from the test file and other usages but feel free to correct them :)
It definitely needs some refinement once more files are converted...