-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cells]: Show Success if there's any data in any of the fields #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 replays were recorded for 41e89e6. 16 PassedrequireAuth graphql checks
|
Talked with @thedavidprice earlier and he doesn't want to spend time trying to get internal working with codemods. So, just going with the copy-into-lib strategy again. Plus @Josh-Walker-GM needs the cell functions for the other cell codemod. |
jtoar
force-pushed
the
ds-fix-cell-empty-behavior
branch
from
March 2, 2023 01:37
777f7a9
to
04e4d5f
Compare
jtoar
force-pushed
the
ds-fix-cell-empty-behavior
branch
from
March 2, 2023 01:50
86c2b9d
to
41e89e6
Compare
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 7, 2023
* 'main' of github.com:redwoodjs/redwood: (50 commits) Use formatCacheKey() when deleting a key (redwoodjs#7362) fix(deps): update dependency @types/node to v16.18.14 (redwoodjs#7739) chore(deps): update dependency @npmcli/arborist to v6.2.4 (redwoodjs#7741) chore(deps): update dependency @replayio/playwright to v0.3.24 (redwoodjs#7738) chore(deps): update dependency @testing-library/react to v14 (redwoodjs#7737) chore(deps): update dependency @testing-library/dom to v9 (redwoodjs#7736) chore(deps): update dependency @types/vscode to v1.76.0 (redwoodjs#7729) chore(deps): update dependency zx to v7.2.0 (redwoodjs#7731) fix(deps): update dependency webpack-bundle-analyzer to v4.8.0 (redwoodjs#7735) fix(deps): update dependency babel-plugin-polyfill-corejs3 to v0.7.1 (redwoodjs#7732) fix(deps): update dependency msw to v1.1.0 (redwoodjs#7733) chore(deps): update dependency @clerk/clerk-react to v4.12.0 (redwoodjs#7728) fix(deps): update dependency @types/node to v16.18.13 (redwoodjs#7727) fix: change isDataEmpty, add codemod, fix codemod (redwoodjs#7704) fix: avoid naming conflict with `client` prop (redwoodjs#7024) fix(deps): update jest monorepo to v29.4.3 (redwoodjs#7651) chore(deps): update dependency @auth0/auth0-spa-js to v2 (redwoodjs#7524) fix(deps): update dependency @types/aws-lambda to v8.10.111 (redwoodjs#7726) fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.7 (redwoodjs#7725) chore(deps): update dependency supertokens-node to v13.1.2 (redwoodjs#7714) ...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7538.
Please note that the codemod is just a work in progress and probably won't ship the way it is. It works when I've tired it locally on a project, but needs tests, and more importantly, to not just copy from
@redwoodjs/internal
.I can't remember the exact details of why we don't import from
@redwoodjs/internal
in the codemods package. It probably had to do with the size of the package, and maybe something with circular dependencies. It's been a while since, so maybe it's ok now and just needs a revisiting.