chore(rwfw): Add force optimise to vite.config when running project:sync #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 23, 2023
…ace-svg-as-components * 'main' of github.com:redwoodjs/redwood: (25 commits) fix(deps): update dependency @whatwg-node/fetch to v0.9.7 (redwoodjs#8702) fix(deps): update dependency @heroicons/react to v2.0.18 (redwoodjs#8701) fix(deps): update dependency @headlessui/react to v1.7.15 (redwoodjs#8700) fix(deps): update dependency webpack to v5.88.0 (redwoodjs#8697) fix(deps): update dependency @graphiql/toolkit to v0.8.4 (redwoodjs#8698) fix(deps): update dependency react-error-boundary to v4.0.10 (redwoodjs#8693) Rename cache file (redwoodjs#8699) fix(clerk): add alternative decoder (redwoodjs#8642) fix(deps): update dependency @vitejs/plugin-react to v4.0.1 (redwoodjs#8692) chore(deps): update dependency @simplewebauthn/server to v7.3.1 (redwoodjs#8690) chore(rwfw): Add force optimise to vite.config when running project:sync (redwoodjs#8688) fix(deps): update storybook monorepo to v7.0.23 (redwoodjs#8696) fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8694) fix(deps): update prisma monorepo to v4.16.1 (redwoodjs#8695) Mark broken gql prerender test as slow (redwoodjs#8687) fix(deps): update dependency @graphiql/plugin-explorer to v0.1.20 (redwoodjs#8691) fix(deps): update typescript-eslint monorepo to v5.60.0 (redwoodjs#8660) fix(deps): update dependency @fastify/http-proxy to v9.2.1 (redwoodjs#8680) chore(deps): update dependency vite to v4.3.9 (redwoodjs#8682) fix(deps): update prisma monorepo to v4.16.0 (redwoodjs#8684) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the project:sync function to:
optimizeDeps.force = trueWhy?
Because Vite will optimize the dependencies once, and when making changes to redwood modules with project:sync, these aren't picked up unless we force a re-optimization.
Note that excluding redwood modules from the optimization stage does not work (errors out in the browser)