-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): Telemetry robustness and command name convention #8747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some incorrect file io with telemetry and made the send.js more robust to json parse failures. Introduced a helper function which will enable existing the process after some required cleanup/shutdown.
Josh-Walker-GM
added
the
release:chore
This PR is a chore (means nothing for users)
label
Jun 26, 2023
Prevents spawning the background send process when it is not needed.
jtoar
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fixture-ok
Override the test project fixture check
release:chore
This PR is a chore (means nothing for users)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Changes
process.on('exit', ...)
event. This ensures telemetry is always shutdowncell
vscell <name>
Minor changes
I'm happy to revert the following changes if they're contentious:
lib/exit.js: exitWithError
. This ensures consistent output styling and consistency in functionality such as setting the exit code.exitWithError
withindevHandler.js
. Minimal usage which occurs only on port collisions.Pushed
try/catch
where they are no longer needed.exitWithError
where it would be appropriate.