chore: Update graphql-server to Yoga v4 and latest subscriptions #8753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
force-pushed
the
dt-gql-yoga-4-updates
branch
from
8cc827d
to
b8452d0
Compare
Josh-Walker-GM
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Looks good to me!
I pushed a change to add a resolution to the e2e tests. Without it I was getting the following error:
Setting a resolution was based on the change made in #7695 which made a similar version change for graphql-yoga
I am happy for that to be reverted if there is a better solution.
jtoar
pushed a commit
that referenced
this pull request
Jun 30, 2023
* WIP v4 yoga and gql updates * Update graphql tools bump * yarn constraints * GraphQLArmor bump * Updates scalars in studio * Updates error masking tests * Resolve yarn * yarn dedupe * Add resolution to e2e --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
There are some new tests for errors to ensure GraphQL errors are not masked.
Also, the behavior of the GraphQL scalar validation message has changed.
it is still an error, but now the message is masked because it is in fact a proper runtime exception (confirmed this behavior with The Guild and is how core Yoga works).
If you are in development, though the original error message about what field failed validation will be present in the extensions.
Note: I don't think this is a breaking change per se, since the scalar behavior is still an error. But, could add in release notes that the message will change.