Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apollo): make previous Apollo Link change breaking #8761

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jun 28, 2023

This is a follow up to #8500.

When I was trying to release that PR, I had a discussion with @thedavidprice about the name of the prop, linkFactory. After coming up with a few names, we decided to just break link instead. The reasons were...

  • the major is coming up
    • if the major was very far away, we probably wouldn't break it, but the RC is more-or-less imminent
  • the users of link aren't many (just my guess), and of those who use it, they'd probably prefer this API to the previous one, which was cumbersome

This PR also includes several stylistic changes to the web/src/apollo/index.tsx file, mainly around comments (changing some /** ... */ comments to //), and around the name of types, preferring longer but more descriptive types.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Jun 28, 2023
@jtoar jtoar changed the title make previous apollo link change breaking chore(apollo): make previous Apollo Link change breaking Jun 28, 2023
@jtoar jtoar added the release:breaking This PR is a breaking change label Jun 28, 2023
@jtoar jtoar added this to the v6.0.0 milestone Jun 28, 2023
@jtoar jtoar removed the release:chore This PR is a chore (means nothing for users) label Jun 28, 2023
@jtoar jtoar merged commit fdd3a14 into main Jun 28, 2023
@jtoar jtoar deleted the ds-v6/make-apollo-link-change-breaking branch June 28, 2023 20:10
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v6.0.0, next-release Jun 28, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant