Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel): Remove preset-env excludes and do not configure them separately #8835

Closed
wants to merge 1 commit into from

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jul 6, 2023

Context
We originally had the excludes block in preset-env - because it was printing warnings when building with babel/webpack 4 (way back when) - see the comment in the removed code for a link to the issue.

So the solution was to exclude it from preset-env, and include it as a separate plugin.

I don't think we need to do this anymore - and seems to work fine with project:copy. But I'm not a 100% sure its all OK until we merge into canary.

@Tobbe
Copy link
Member

Tobbe commented Jul 6, 2023

With this change we'll now get the default behavior of loose: false, right? Do you know exactly why we had loose: true?

@dac09
Copy link
Collaborator Author

dac09 commented Jul 6, 2023

With this change we'll now get the default behavior of loose: false, right? Do you know exactly why we had loose: true?

Yeah it was a webpack 4 thing. webpack/webpack#9708

@dac09 dac09 marked this pull request as ready for review July 6, 2023 11:27
@dac09 dac09 added this to the v6.0.0 milestone Jul 6, 2023
@Tobbe
Copy link
Member

Tobbe commented Jul 6, 2023

The linked issue doesn't mention "loose" anywhere. The linked issue seems to be more about why we include these, and then exclude them later

Reading the babel docs however it says

When true, private methods will be assigned directly on its parent via Object.defineProperty rather than a WeakSet. This results in improved performance and debugging

@dac09
Copy link
Collaborator Author

dac09 commented Jul 6, 2023

I did this change Tobbe, so I remember.

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Jul 6, 2023
@dac09
Copy link
Collaborator Author

dac09 commented Jul 6, 2023

lol I'm actually not sure about loose anymore. This is the old PR #2554 - but trying to find one where loose was enabled.

@jtoar jtoar modified the milestones: v6.0.0, next-release Jul 27, 2023
@jtoar jtoar modified the milestones: next-release, v6.1.0 Aug 12, 2023
@jtoar jtoar modified the milestones: next-release, v6.2.0 Sep 2, 2023
@jtoar jtoar modified the milestones: next-release, v6.3.0 Sep 16, 2023
@dac09 dac09 closed this Oct 16, 2023
@jtoar jtoar removed this from the next-release milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants