Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): remove classic code from repository #1051

Merged
merged 38 commits into from
Jul 17, 2024
Merged

chore(web): remove classic code from repository #1051

merged 38 commits into from
Jul 17, 2024

Conversation

mulengawilfred
Copy link
Contributor

@mulengawilfred mulengawilfred commented Jul 9, 2024 •
edited
Loading

Overview

  • Deleted components and services used by classic but not used by beta.
  • Moved a RootPage page that might still be required along with the corresponding graphql query.
  • Refactored some styling to remove classic references but the styling change might not be 100% correct.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@github-actions github-actions bot added the web label Jul 9, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b59445e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/66979cac7ea28d00085d31f7
😎 Deploy Preview https://deploy-preview-1051--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mulengawilfred mulengawilfred changed the title chore: migrate account and workspace pages to beta folder chore: migrate account, rootpage and workspace pages to beta folder Jul 9, 2024
@mulengawilfred mulengawilfred changed the title chore: migrate account, rootpage and workspace pages to beta folder chore: remove classic code from repository Jul 12, 2024
@mulengawilfred mulengawilfred changed the title chore: remove classic code from repository [DRAFT] chore: remove classic code from repository Jul 16, 2024
@mulengawilfred mulengawilfred changed the title [DRAFT] chore: remove classic code from repository chore: remove classic code from repository Jul 17, 2024
@airslice airslice requested a review from rot1024 as a code owner July 17, 2024 09:24
@airslice airslice changed the title chore: remove classic code from repository chore(web): remove classic code from repository Jul 17, 2024
@airslice airslice merged commit 6af06a1 into main Jul 17, 2024
12 checks passed
@airslice airslice deleted the chore/remove-classic-code branch July 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumbobeaty mkumbobeaty mkumbobeaty approved these changes

@airslice airslice airslice approved these changes

@m-abe-dev m-abe-dev Awaiting requested review from m-abe-dev

@keiya01 keiya01 Awaiting requested review from keiya01

@rot1024 rot1024 Awaiting requested review from rot1024 rot1024 is a code owner

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mulengawilfred @mkumbobeaty @airslice