Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): scene settings inspector #1058

Merged
merged 11 commits into from
Jul 18, 2024
Merged

Conversation

mkumbobeaty
Copy link
Contributor

Overview

-Refactor scene settings inspector to use current beta UI fields

What I've done

  • refactor property fields to use current fields component
  • use Number input field for all slider field while waiting for slider design to be complete
  • refactor scene settings inspector panel

What I haven't done

  • slider fields and range field component not yet have clear design so not using them in property field

How I tested

Which point I want you to review particularly

Memo

@mkumbobeaty mkumbobeaty marked this pull request as ready for review July 17, 2024 07:56
@github-actions github-actions bot added the web label Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3919e18
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6698ba35b8a62d0008356db4
😎 Deploy Preview https://deploy-preview-1058--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot requested a review from pyshx July 17, 2024 07:56
@mkumbobeaty mkumbobeaty merged commit 1de9eb0 into main Jul 18, 2024
12 checks passed
@mkumbobeaty mkumbobeaty deleted the refactor/property-fields branch July 18, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants