chore(web, server): add migration for ga support #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pyshx
requested changes
May 16, 2024
|
|
||
| var seeds []seed | ||
|
|
||
| col.Find(ctx, bson.M{}, &mongox.BatchConsumer{ |
There was a problem hiding this comment.
Instead of just logging errors, consider returning them from the CopySceneId function. This will allow the caller to handle errors appropriately.
There was a problem hiding this comment.
fixed in 634a084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
implement a migration for ga
What I haven't done
How I tested
created migration test case
Which point I want you to review particularly
Memo