Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: clustering layers #143

Merged
merged 13 commits into from
Dec 17, 2021
Merged

feat: clustering layers #143

merged 13 commits into from
Dec 17, 2021

Conversation

issmail-basel
Copy link
Contributor

@issmail-basel issmail-basel commented Dec 14, 2021

Overview

What I've done

  • Added clusters right Panel UI
  • Added Cluster component
  • Linked clusters front-end to back-end
  • Add options to customize clusters

How I tested

  • Add new cluster
  • Customize it's look
  • Add layers to it
  • Publish project

Screenshot

Screenshot from 2021-12-17 05-46-36

@netlify
Copy link

netlify bot commented Dec 14, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: fcf5e3e

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61bc05e7d6b8c90007ef0c36

😎 Browse the preview: https://deploy-preview-143--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #143 (fcf5e3e) into main (dae1376) will decrease coverage by 0.19%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   44.42%   44.22%   -0.20%     
==========================================
  Files          56       56              
  Lines        1121     1135      +14     
  Branches      179      179              
==========================================
+ Hits          498      502       +4     
- Misses        570      580      +10     
  Partials       53       53              
Impacted Files Coverage Δ
src/state/index.ts 77.41% <ø> (ø)
src/gql/graphql-client-api.tsx 36.41% <28.57%> (-0.34%) ⬇️

@issmail-basel issmail-basel marked this pull request as ready for review December 17, 2021 03:48
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring points (outside the scope of the PR):

  • Standardize the implementation of Primitive component rendering: Cluster can accept children prop and render it.
  • propertyRef in Cluster/index.tsx is not needed. The hooks can be simplified.

@rot1024 rot1024 changed the title feat: add clusters feat: clustering layers Dec 17, 2021
@rot1024 rot1024 merged commit 3439cc1 into main Dec 17, 2021
@rot1024 rot1024 deleted the cluster-latest branch December 17, 2021 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants