This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: fcf5e3e 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61bc05e7d6b8c90007ef0c36 😎 Browse the preview: https://deploy-preview-143--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 44.42% 44.22% -0.20%
==========================================
Files 56 56
Lines 1121 1135 +14
Branches 179 179
==========================================
+ Hits 498 502 +4
- Misses 570 580 +10
Partials 53 53
|
rot1024
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring points (outside the scope of the PR):
- Standardize the implementation of Primitive component rendering: Cluster can accept children prop and render it.
- propertyRef in Cluster/index.tsx is not needed. The hooks can be simplified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
How I tested
Screenshot