Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

refactor: camera limiter #149

Merged
merged 11 commits into from
Jan 21, 2022
Merged

refactor: camera limiter #149

merged 11 commits into from
Jan 21, 2022

Conversation

issmail-basel
Copy link
Contributor

@issmail-basel issmail-basel commented Dec 21, 2021

Overview

What I've done

  • Separate camera limiter logic into it's own file.
  • Create clear pure functions for limiter calculations.

What I haven't done

  • I did not change the logic or any functionality code.

How I tested

  • same as the old camera limiter
  • Editor
    • Choose a place and click on (camera input)
    • Show/hide helper
    • Enable/disable camera limiter
    • Change width/length of the area
    • Re-enable camera limiter
    • Preview result with limiter enabled and helper is on
      • Try to move to the edge
      • Try to zoom out
    • Preview result with limiter enabled and helper is off
    • Publish project with limiter enabled and helper is on
    • Publish project with limiter enabled and helper is off

Screenshot

Screenshot from 2022-01-06 08-20-52

Which point I want you to review particularly

  • Code enhancements/improvement.

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: af2663b

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61e913b9a4815a000743f071

😎 Browse the preview: https://deploy-preview-149--reearth-web.netlify.app

@issmail-basel issmail-basel changed the title Refactor limiter chore: refactor camera limiter Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #149 (af2663b) into main (db6e6cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   45.48%   45.48%           
=======================================
  Files          60       60           
  Lines        1284     1284           
  Branches      205      205           
=======================================
  Hits          584      584           
  Misses        641      641           
  Partials       59       59           

@issmail-basel issmail-basel marked this pull request as ready for review January 6, 2022 06:22
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments and update!

@issmail-basel issmail-basel changed the title chore: refactor camera limiter refactor: camera limiter Jan 17, 2022
@issmail-basel issmail-basel enabled auto-merge (squash) January 20, 2022 07:51
@issmail-basel issmail-basel merged commit 1054287 into main Jan 21, 2022
@issmail-basel issmail-basel deleted the refactor-limiter branch January 21, 2022 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants