This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: af2663b 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61e913b9a4815a000743f071 😎 Browse the preview: https://deploy-preview-149--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 45.48% 45.48%
=======================================
Files 60 60
Lines 1284 1284
Branches 205 205
=======================================
Hits 584 584
Misses 641 641
Partials 59 59 |
KaWaite
reviewed
Jan 9, 2022
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jan 9, 2022
KaWaite
reviewed
Jan 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments and update!
issmail-basel
changed the title
chore: refactor camera limiter
refactor: camera limiter
Jan 17, 2022
rot1024
approved these changes
Jan 18, 2022
rot1024
approved these changes
Jan 20, 2022
rot1024
suggested changes
Jan 20, 2022
src/components/molecules/Visualizer/Engine/Cesium/cameraLimiter.ts
Outdated
Show resolved
Hide resolved
rot1024
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly