Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: workspace settings does not refresh #167

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

issmail-basel
Copy link
Contributor

Overview

Fixes

What I've done

Updating team state after crud operation.

How I tested

  • Add new member to workspace
  • Edit a member role
  • delete a member

Screenshot

Screencast.2022-01-30.05.09.51.mp4

@netlify
Copy link

netlify bot commented Jan 30, 2022

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: f0a31bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61fcb951479b49000841692a

😎 Browse the preview: https://deploy-preview-167--reearth-web.netlify.app/

@issmail-basel issmail-basel changed the title Fix/workspace settings dont refresh fix: workspace settings does not refresh Jan 30, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #167 (f0a31bf) into main (17d9682) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   45.39%   45.39%           
=======================================
  Files          60       60           
  Lines        1302     1302           
  Branches      207      207           
=======================================
  Hits          591      591           
  Misses        652      652           
  Partials       59       59           

@issmail-basel issmail-basel added the bug Something isn't working label Jan 31, 2022
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check my reviews. 👍

src/components/organisms/Settings/Workspace/hooks.ts Outdated Show resolved Hide resolved
src/components/organisms/Settings/Workspace/hooks.ts Outdated Show resolved Hide resolved
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@issmail-basel issmail-basel enabled auto-merge (squash) February 4, 2022 06:20
@issmail-basel issmail-basel merged commit 0f3654c into main Feb 8, 2022
@issmail-basel issmail-basel deleted the fix/workspace-settings-dont-refresh branch February 8, 2022 02:31
@lavalse
Copy link
Member

lavalse commented Feb 8, 2022

@Basel-Issmail When you have time, Can we test this task a little bit again ? Because I test on test env, some similar bug still there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants