Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: allowing widget and block plugins to resize when they are expandable #170

Merged
merged 13 commits into from
Feb 9, 2022

Conversation

issmail-basel
Copy link
Contributor

@issmail-basel issmail-basel commented Feb 4, 2022

Overview

Plugin developers want to be able to stretch 100% vertically or horizontally, and resize in the opposite direction. related issue

What I've done

  • Auto resize now differentiate between two modes autoResizeHorizontally and autoResizeVertically.

What I haven't done

How I tested

  • Added multiple widgets which supports horizontal and vertical extending.

Screenshot

Before:
1
After:
2

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: 2d17c4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6203925bceac5e000841a0e6

😎 Browse the preview: https://deploy-preview-170--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #170 (2d17c4f) into main (4e5b61e) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   45.39%   45.21%   -0.18%     
==========================================
  Files          60       60              
  Lines        1302     1307       +5     
  Branches      207      212       +5     
==========================================
  Hits          591      591              
- Misses        652      657       +5     
  Partials       59       59              
Impacted Files Coverage Δ
src/components/atoms/Plugin/IFrame/hooks.ts 49.18% <0.00%> (-1.67%) ⬇️
src/components/atoms/Plugin/IFrame/index.tsx 75.00% <0.00%> (ø)
src/components/atoms/Plugin/index.tsx 25.00% <ø> (ø)
...rc/components/molecules/Visualizer/Plugin/hooks.ts 0.00% <0.00%> (ø)
...c/components/molecules/Visualizer/Plugin/index.tsx 0.00% <0.00%> (ø)

@issmail-basel issmail-basel marked this pull request as ready for review February 4, 2022 12:03
src/components/atoms/Plugin/IFrame/hooks.ts Outdated Show resolved Hide resolved
src/components/molecules/Visualizer/Plugin/hooks.ts Outdated Show resolved Hide resolved
@rot1024 rot1024 changed the title feat: allowing Widget plugin's to resize when it's expandable feat: allowing widget and block plugins to resize when they are expandable Feb 7, 2022
@rot1024
Copy link
Member

rot1024 commented Feb 7, 2022

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good, but I have more in-depth advice.

src/components/molecules/Visualizer/Plugin/hooks.ts Outdated Show resolved Hide resolved
src/components/molecules/Visualizer/Plugin/hooks.ts Outdated Show resolved Hide resolved
@issmail-basel issmail-basel enabled auto-merge (squash) February 9, 2022 10:07
@issmail-basel issmail-basel merged commit 4fdf5f9 into main Feb 9, 2022
@issmail-basel issmail-basel deleted the feat/resize-widgets branch February 9, 2022 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants