This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: add a plugin API to resize iframe by plugins #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 1f9f991 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6220a78d668aaf00073f10d0 😎 Browse the preview: https://deploy-preview-181--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 45.14% 44.74% -0.41%
==========================================
Files 60 60
Lines 1309 1323 +14
Branches 212 215 +3
==========================================
+ Hits 591 592 +1
- Misses 659 669 +10
- Partials 59 62 +3
|
rot1024
changed the title
rot1024
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type PluginAPIUI = { // ... render: (html: string, options: { visible?: boolean; + width?: number | string; + height?: number | string; + extended?: boolean; }) => void; + resize: ( + width: number | string | undefined, + height: number | string | undefined, + extended: boolean | undefined + ) => void; };