This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: implementation of the avatar feature in workspaces screens #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 60 60
Lines 1350 1350
Branches 227 227
=======================================
Hits 590 590
Misses 698 698
Partials 62 62
|
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
src/components/molecules/Settings/Project/EditableItem/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Apr 18, 2022
src/components/molecules/Settings/Project/EditableItem/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Apr 18, 2022
src/components/molecules/Settings/Workspace/MemberListItem/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Apr 18, 2022
src/components/molecules/Settings/Project/EditableItem/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
reviewed
Apr 18, 2022
KaWaite
suggested changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the PR title because "avatar system" is abstract so that most people cannot understand what is changed in UI: e.g.
|
And also update this page ( account setting page ) please . design is here |
nina992
changed the title
feat: adding avatar system
feat: implementation of the avatar feature
Apr 20, 2022
nina992
changed the title
feat: implementation of the avatar feature
feat: implementation of the avatar feature in workspaces screens
Apr 21, 2022
KaWaite
reviewed
Apr 22, 2022
KaWaite
reviewed
Apr 22, 2022
KaWaite
approved these changes
Apr 22, 2022
issmail-basel
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments to answer
issmail-basel
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A simple avatar feature makes the UX a little bit better, and also to solve some style issues like Workspace banner stretching with many members
What I've done
Match the new feature with the design (https://www.figma.com/file/bdnfDaGXGoNfUws4y7JItl/Re%3AEarth-UI-Gamma?node-id=9967%3A176976)
Main changes in Code are :
What I haven't done
I tried to fix this bug Broken alignment inside settings pages
How I tested
Screenshot
Which point I want you to review particularly
Memo