Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: implementation of the avatar feature in workspaces screens #206

Merged
merged 6 commits into from
Apr 26, 2022

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Apr 15, 2022

Overview

A simple avatar feature makes the UX a little bit better, and also to solve some style issues like Workspace banner stretching with many members

What I've done

  1. Adding the avatar feature for below pages :
  • Workspace section in Dashboard page
  • Member list related to member section in workspace setting page
  • Members section in each workspace in workspace list page
  • profile picture in account page
  1. Match the new feature with the design (https://www.figma.com/file/bdnfDaGXGoNfUws4y7JItl/Re%3AEarth-UI-Gamma?node-id=9967%3A176976)

  2. Main changes in Code are :

    1. Adding a new Atom component (Avatar)
    2. Adding a new color in both (light & dark ) themes
    3. Refactoring the MemberlistEdit component
    4. Adding subHeader that could be used in field component

What I haven't done

I tried to fix this bug Broken alignment inside settings pages

How I tested

  1. Check the navigation bar avatar and make sure that it matches the design
  2. check the workspace section in dashboard and make sure it matches the design
  3. check the member list in workspace setting page make sure that the list shows the email- the right design
  4. check the members in workspace list

Screenshot

image
imageimage

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Apr 15, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit a76681a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6266f0a1d8a3070008a6223b
😎 Deploy Preview https://deploy-preview-206--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nina992 nina992 changed the title feat: adding-avatar-system feat: adding avatar system Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #206 (a76681a) into main (2afc16e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   43.70%   43.70%           
=======================================
  Files          60       60           
  Lines        1350     1350           
  Branches      227      227           
=======================================
  Hits          590      590           
  Misses        698      698           
  Partials       62       62           
Impacted Files Coverage Δ
src/theme/colors.ts 100.00% <ø> (ø)
src/theme/darkTheme.ts 100.00% <ø> (ø)
src/theme/lightheme.ts 100.00% <ø> (ø)
src/theme/theme.ts 100.00% <ø> (ø)

@nina992 nina992 marked this pull request as ready for review April 15, 2022 18:56
@nina992 nina992 requested a review from KaWaite as a code owner April 15, 2022 18:56
src/theme/darkTheme.ts Outdated Show resolved Hide resolved
src/theme/lightheme.ts Outdated Show resolved Hide resolved
src/theme/theme.ts Outdated Show resolved Hide resolved
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions, comments and asked for some changes!

Also, UI-based observations:

  • Dashboard icon isn't centered

Screen Shot 2022-04-18 at 9 42 31

- Navbar avatar isn't updated - The role and buttons (this screenshot doesn't show the buttons bc its my personal workspace) aren't centered really with the title AND subtitle

@rot1024
Copy link
Member

rot1024 commented Apr 18, 2022

Rename the PR title because "avatar system" is abstract so that most people cannot understand what is changed in UI:

e.g.

  • feat: display avatars in the workspace screen

@lavalse
Copy link
Member

lavalse commented Apr 19, 2022

And also don't forget to update the navigation header 😂
1650349452(1)

@lavalse
Copy link
Member

lavalse commented Apr 20, 2022

And also update this page ( account setting page ) please .
1650423529

design is here

@nina992 nina992 changed the title feat: adding avatar system feat: implementation of the avatar feature Apr 20, 2022
@nina992 nina992 changed the title feat: implementation of the avatar feature feat: implementation of the avatar feature in workspaces screens Apr 21, 2022
Copy link
Contributor

@issmail-basel issmail-basel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to answer

src/components/atoms/Avatar/index.tsx Show resolved Hide resolved
src/components/atoms/Avatar/index.tsx Show resolved Hide resolved
@issmail-basel issmail-basel self-requested a review April 26, 2022 08:35
@KaWaite KaWaite merged commit 42d7aac into main Apr 26, 2022
@KaWaite KaWaite deleted the avatar-system branch April 26, 2022 08:55
airslice added a commit that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants