Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

refactor: cluster, dataset, infobox, layer, plugin and project gql query files #219

Merged
merged 14 commits into from
May 9, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented May 9, 2022

close reearth/reearth-visualizer#272

Overview

Cleaning GraphQL queries and mutations following standards written in reearth/reearth-visualizer#272

This is the 2/3 PR of the series task.

This PR includes the cleaning of:

  • cluster.ts
  • dataset.ts
  • infobox.ts
  • layer.ts
  • plugin.ts
  • project.ts

What I've done

  • cluster:

    • PascalCase removeCluster
  • dataset:

    • update query name datasetSchemas to GetDatasetSchemas
    • PascalCaseimportGoogleSheetDataset
    • reorder mutation exports
  • infobox:

    • PascalCase getBlocks createInfobox removeInfobox addInfoboxField moveInfoboxField removeInfoboxField
    • reorder mutation exports
  • layer:

    • PascalCase moveLayer addLayerGroupFromDatasetSchema
    • reorder mutation exports
  • plugin:

    • update query name InstallablePlugins to GetInstallablePlugins
    • update query name InstalledPlugins to GetInstalledPlugins
    • PascalCase uninstallPlugin
  • project:

    • update query name Project to GetProjects
    • PascalCase updateProject deleteProject updateProjectAlias archiveProject updateProjectBasicAuth
    • reorder mutation exports
  • update related hooks

  • generate the gql api tsx

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5061e64
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6278ba4f6d74e700089463b7
😎 Deploy Preview https://deploy-preview-219--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #219 (5061e64) into main (c6c6e36) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   43.97%   43.99%   +0.02%     
==========================================
  Files          63       63              
  Lines        1360     1357       -3     
  Branches      228      228              
==========================================
- Hits          598      597       -1     
+ Misses        699      697       -2     
  Partials       63       63              
Impacted Files Coverage Δ
src/gql/graphql-client-api.tsx 36.04% <ø> (+0.02%) ⬆️

@airslice airslice marked this pull request as ready for review May 9, 2022 02:59
@airslice airslice requested a review from KaWaite as a code owner May 9, 2022 02:59
src/gql/queries/dataset.ts Outdated Show resolved Hide resolved
src/gql/queries/dataset.ts Outdated Show resolved Hide resolved
src/gql/queries/plugin.ts Outdated Show resolved Hide resolved
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes I asked for and then should be good to go!

@airslice
Copy link
Contributor Author

airslice commented May 9, 2022

got it. resolving now

@KaWaite KaWaite changed the title Refactor: clean gql pt2 to pt7 Refactor: cluster, dataset, infobox, layer, plugin and project gql query files May 9, 2022
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@airslice airslice merged commit e4dae97 into main May 9, 2022
@airslice airslice deleted the refactor/clean-gql-pt2-to-pt7 branch May 9, 2022 07:01
@airslice airslice changed the title Refactor: cluster, dataset, infobox, layer, plugin and project gql query files refactor: cluster, dataset, infobox, layer, plugin and project gql query files May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE]: GraphQL queries and mutations need cleaning up pt.2
2 participants