This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: cluster, dataset, infobox, layer, plugin and project gql query files #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 43.97% 43.99% +0.02%
==========================================
Files 63 63
Lines 1360 1357 -3
Branches 228 228
==========================================
- Hits 598 597 -1
+ Misses 699 697 -2
Partials 63 63
|
KaWaite
reviewed
May 9, 2022
KaWaite
reviewed
May 9, 2022
KaWaite
reviewed
May 9, 2022
KaWaite
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes I asked for and then should be good to go!
got it. resolving now |
KaWaite
changed the title
Refactor: clean gql pt2 to pt7
Refactor: cluster, dataset, infobox, layer, plugin and project gql query files
May 9, 2022
KaWaite
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
airslice
changed the title
Refactor: cluster, dataset, infobox, layer, plugin and project gql query files
refactor: cluster, dataset, infobox, layer, plugin and project gql query files
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reearth/reearth-visualizer#272
Overview
Cleaning GraphQL queries and mutations following standards written in reearth/reearth-visualizer#272
This is the 2/3 PR of the series task.
This PR includes the cleaning of:
What I've done
cluster:
removeCluster
dataset:
datasetSchemas
toGetDatasetSchemas
importGoogleSheetDataset
infobox:
getBlocks
createInfobox
removeInfobox
addInfoboxField
moveInfoboxField
removeInfoboxField
layer:
moveLayer
addLayerGroupFromDatasetSchema
plugin:
InstallablePlugins
toGetInstallablePlugins
InstalledPlugins
toGetInstalledPlugins
uninstallPlugin
project:
Project
toGetProjects
updateProject
deleteProject
updateProjectAlias
archiveProject
updateProjectBasicAuth
update related hooks
generate the gql api tsx