Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

refactor: property, scene, tag, user, widget and workspace gql query files #221

Merged
merged 19 commits into from
May 9, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented May 9, 2022

close reearth/reearth-visualizer#272

Overview

Cleaning GraphQL queries and mutations following standards written in reearth/reearth-visualizer#272

This is the 3/3 PR of the series task.

This PR includes the cleaning of:

  • property.ts
  • scene.ts
  • tag.ts
  • user.ts
  • widget.ts
  • workspace.ts

What I've done

  • property:

    • PascalCase movePropertyItem removePropertyItem updatePropertyItems
    • reorder mutation exports
  • scene:

    • update query name Scene to GetProjectScene
    • PascalCasegetScene addLayerItemFromPrimitive
  • tag:

    • PascalCase getSceneTags getLayerTags createTagGroup createTagItem removeTag attachTagItemToGroup detachTagItemFromGroup attachTagToLayer detachTagFromLayer
    • reorder mutation exports
  • user:

    • update query name searchUser to GetUserBySearch
    • update query name Me to GetMe
    • update query name Profile to GetProfile
    • update query name Language to GetLanguage
    • update query name Theme to GetTheme
    • PascalCase updateMe deleteMe
  • widget:

    • PascalCase addWidget removeWidget updateWidget updateWidgetAlignSystem
  • workspace:

    • update query name teams to GetTeams
    • PascalCase updateTeam deleteTeam addMemberToTeam updateMemberOfTeam removeMemberFromTeam createTeam
    • reorder mutation exports
  • update related hooks

  • generate the gql api tsx

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ff90a5a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6278f5ada4d7b700089a0458
😎 Deploy Preview https://deploy-preview-221--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@airslice airslice changed the title Refactor: property, scene, tag, user, widget, workspace Refactor: property, scene, tag, user, widget and workspace gql query files May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #221 (ff90a5a) into main (e4dae97) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   43.99%   43.99%           
=======================================
  Files          63       63           
  Lines        1357     1357           
  Branches      228      228           
=======================================
  Hits          597      597           
  Misses        697      697           
  Partials       63       63           
Impacted Files Coverage Δ
src/gql/graphql-client-api.tsx 36.04% <ø> (ø)
src/i18n/legacy/provider.tsx 75.00% <100.00%> (ø)
src/i18n/provider.tsx 83.33% <100.00%> (ø)
src/theme/provider.tsx 80.00% <100.00%> (ø)

@airslice airslice marked this pull request as ready for review May 9, 2022 09:06
@airslice airslice requested a review from KaWaite as a code owner May 9, 2022 09:06
@airslice airslice changed the title Refactor: property, scene, tag, user, widget and workspace gql query files refactor: property, scene, tag, user, widget and workspace gql query files May 9, 2022
src/gql/queries/property.ts Outdated Show resolved Hide resolved
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Queries and mutations are looking much better.

@airslice airslice merged commit 3bf4215 into main May 9, 2022
@airslice airslice deleted the refactor/clean-gql-pt8-to-pt13 branch May 9, 2022 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE]: GraphQL queries and mutations need cleaning up pt.2
2 participants