Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: vertical position style in infobox image block #236

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented May 30, 2022

Overview

I fixed reearth/reearth-visualizer#202.

What I've done

I fixed to use height: 100%; when vertical position property is specified center in infobox image block.

What I haven't done

How I tested

Screenshot

Before After
Screen Shot 2022-05-30 at 20 57 28 Screen Shot 2022-05-30 at 20 57 38

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this May 30, 2022
@netlify
Copy link

netlify bot commented May 30, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b938c7d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62988c2adefe74000810223b
😎 Deploy Preview https://deploy-preview-236--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keiya01 keiya01 force-pushed the feature/fix-image-position branch from 4942e46 to be11a2e Compare May 30, 2022 12:16
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #236 (1df5e56) into main (723486d) will decrease coverage by 0.73%.
The diff coverage is n/a.

❗ Current head 1df5e56 differs from pull request most recent head b938c7d. Consider uploading reports for the commit b938c7d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   51.72%   50.98%   -0.74%     
==========================================
  Files          58       58              
  Lines        1162     1165       +3     
  Branches      184      184              
==========================================
- Hits          601      594       -7     
- Misses        497      508      +11     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
src/config.ts 18.91% <0.00%> (-8.01%) ⬇️
src/state/index.ts 77.41% <0.00%> (-1.37%) ⬇️
src/i18n/index.tsx 100.00% <0.00%> (ø)
src/theme/provider.tsx 80.00% <0.00%> (ø)

Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rot1024 rot1024 changed the title fix: fix vertical position style in infobox image block, closes reearth/reearth#202 fix: fix vertical position style in infobox image block Jun 1, 2022
@rot1024 rot1024 changed the title fix: fix vertical position style in infobox image block fix: vertical position style in infobox image block Jun 1, 2022
@keiya01 keiya01 enabled auto-merge (squash) June 2, 2022 10:09
@keiya01 keiya01 merged commit 647cf8e into main Jun 2, 2022
@keiya01 keiya01 deleted the feature/fix-image-position branch June 2, 2022 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image vertical position property for image block doesn't work
3 participants