This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: labeling hidden by marker symbol #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 51.72% 51.75% +0.03%
==========================================
Files 58 58
Lines 1162 1165 +3
Branches 184 184
==========================================
+ Hits 601 603 +2
- Misses 497 498 +1
Partials 64 64
|
nourbalaha
changed the title
rot1024
suggested changes
Jun 2, 2022
src/components/molecules/Visualizer/Engine/Cesium/Marker/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Visualizer/Engine/Cesium/Marker/index.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: rot1024 <aayhrot@gmail.com>
rot1024
suggested changes
Jun 3, 2022
src/components/molecules/Visualizer/Engine/Cesium/Marker/index.tsx
Outdated
Show resolved
Hide resolved
rot1024
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR I fixed the bug where the label is hidden behind the marker image
this fixes reearth/reearth-visualizer#207 and reearth/reearth-visualizer#184 reearth-web
What I've done
I modified the
pixelOffsethook insidesrc/components/molecules/Visualizer/Engine/Cesium/Marker/index.tsxand updated the equations for x and y with taking imageSize(imageScale) in condsideration.
How I tested
Manually using google chrome.
Screenshot