-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: migrate to react-intl from react-i18next #240
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 51.48% 51.24% -0.25%
==========================================
Files 58 56 -2
Lines 1175 1163 -12
Branches 184 182 -2
==========================================
- Hits 605 596 -9
+ Misses 506 505 -1
+ Partials 64 62 -2
|
fix: use key as english translation |
b83c3a5
to
0269772
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Delete
i18n:legacy
script inpackage.json
also. - Resolve conflict, but It would not be a problem to override change in this PR.
- CI failed. CI is set up to report an error if there are missing translation. Rerun
yarn i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the config files only, but everything looks good! I asked for a single change, so please do that before merging.
Also, I'll approve, but can you please test storybook locally? The PR's preview deploy on netlify failed. Sometimes changes to yarn.lock, especially deleting yarn.lock and regenerating, will break storybook....
If it fails on local as well, please investigate, fix and ask for a re-review! If it works locally it might be an issue with redeployment on netfliy and should be okay for us.
Overview
What I've done
I replaced react-intl with react-i18next.
And I removed react-intl pkg.
closes reearth/reearth-visualizer#172.
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
replacing script
Memo