This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: layers pane does not update after move layer or create folder #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 51.33% 51.33%
=======================================
Files 56 56
Lines 1165 1165
Branches 182 182
=======================================
Hits 598 598
Misses 505 505
Partials 62 62 |
KaWaite
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bug: when click on the 'create new folder' or move layer on the Outline pane -> layers, the layers list did not got update which will mislead the users.
What I've done
Add refetch to
moveLayerMutationandaddLayerGroupMutationHow I tested
Screenshot
Which point I want you to review particularly
It seems to be an obvious bug and i'm not sure when it starts to happen.