Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: unselect layer not work properly #266

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Jul 8, 2022

Overview

When click on blank space of map it should unselect layers but it doesn't work due to a bug.

The bug comes from updateing selectLayer functions of organisms CanvasArea and molecusles Visualizer. In the past the CanvasArea select funtion will check if the layer can be got by layers.findById and after update this condition should be moved into Visualizer selectLayer function. When reviewing, the code looks like can be refactored and i did it without thinking clearly. My mistake.

What I've done

Update the selectLayer function.

What I haven't done

How I tested

Select layer and click on blank space to unselect it.

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c915512
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/62c7aed800f22400096ccd5a
😎 Deploy Preview https://deploy-preview-266--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #266 (c915512) into main (6468e2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   52.19%   52.19%           
=======================================
  Files          56       56           
  Lines        1205     1205           
  Branches      193      193           
=======================================
  Hits          629      629           
  Misses        503      503           
  Partials       73       73           

@airslice airslice marked this pull request as ready for review July 8, 2022 04:23
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@airslice airslice merged commit eb41daf into main Jul 8, 2022
@airslice airslice deleted the fix/unselect-layer-not-work-properly branch July 8, 2022 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants