This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When click on blank space of map it should unselect layers but it doesn't work due to a bug.
The bug comes from updateing selectLayer functions of organisms
CanvasArea
and molecuslesVisualizer
. In the past theCanvasArea
select funtion will check if the layer can be got bylayers.findById
and after update this condition should be moved intoVisualizer
selectLayer function. When reviewing, the code looks like can be refactored and i did it without thinking clearly. My mistake.What I've done
Update the
selectLayer
function.What I haven't done
How I tested
Select layer and click on blank space to unselect it.
Screenshot
Which point I want you to review particularly
Memo