This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
fix: select not working after pinch event on ipad #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 14.30% 14.37% +0.07%
==========================================
Files 481 481
Lines 46159 46163 +4
Branches 392 402 +10
==========================================
+ Hits 6602 6636 +34
+ Misses 39543 39513 -30
Partials 14 14
|
airslice
changed the title
fix: select not working after zoom on ipad
fix: select not working after pinch event on ipad
Aug 3, 2022
KaWaite
approved these changes
Aug 4, 2022
rot1024
approved these changes
Aug 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Touch to select does not work after pinch event on iPad.
This bug comes from unproper handle of pinch event props.
The pinch events are added with mouse events as a nice-to-have feature. Since the data type definiation is same with the mouse event props i didn't pay additional attention on the data but it turns out to be different.
After discuss with Red we decide to remove pinch events, the reasons are:
Also if we got some requirements in detail about pinch events, we can add them back with certain design.
What I've done
pinchstart
pinchmove
pinchend
events.What I haven't done
How I tested
Select layer -> zoom in/out -> select layer on iPad visiting the deploy preview site.
Screenshot
Which point I want you to review particularly
Memo