Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: Basic auth for projects #3

Merged
merged 7 commits into from
Jun 3, 2021
Merged

feat: Basic auth for projects #3

merged 7 commits into from
Jun 3, 2021

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented May 31, 2021

related: reearth/reearth-backend#6

What I made change

  • Created the section to set the basic authorization settings
  • Implemented the mutation and hooks
  • Added the new section component

What I especially want to get reviewed

  • If the mutation is OK
  • Any part which can be generalized

How I tested

  • Executed the mutation and the expected value returned and displayed

Screenshot

bab06a776bc306252e12178f1d5ec948

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #3 (00af1fa) into main (0edf587) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   52.60%   52.59%   -0.01%     
==========================================
  Files          44       44              
  Lines         633      635       +2     
  Branches      122      122              
==========================================
+ Hits          333      334       +1     
- Misses        225      226       +1     
  Partials       75       75              
Impacted Files Coverage Δ
src/gql/graphql-client-api.tsx 52.65% <ø> (-0.03%) ⬇️

@rot1024 rot1024 changed the title feat: basic auth feat: Basic auth for the project May 31, 2021
@rot1024 rot1024 changed the title feat: Basic auth for the project feat: Basic auth for projects May 31, 2021
rot1024
rot1024 previously approved these changes May 31, 2021
KaWaite
KaWaite previously approved these changes May 31, 2021
@HideBa HideBa dismissed stale reviews from KaWaite and rot1024 via 00af1fa June 3, 2021 05:08
@rot1024 rot1024 merged commit 372c4e8 into main Jun 3, 2021
@rot1024 rot1024 deleted the feat/basic-auth branch June 3, 2021 05:22
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants