Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

chore: Plugin component supports modalContainer and popupContainer props #300

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Aug 25, 2022

This pull request adds the modalContainer, popupContainer, modalCanBeVisible, and popupCanBeVisible properties to the atoms/Plugin component. Also, exposed property of the Plugin component now exposes various APIs for modals and popups.

@rot1024 rot1024 requested a review from KaWaite as a code owner August 25, 2022 05:39
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 90e727e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/630eedb37bebf900088220ff
😎 Deploy Preview https://deploy-preview-300--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #300 (90e727e) into main (7362aaa) will increase coverage by 0.26%.
The diff coverage is 65.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   16.42%   16.69%   +0.26%     
==========================================
  Files         497      500       +3     
  Lines       48244    48512     +268     
  Branches      520      520              
==========================================
+ Hits         7925     8097     +172     
- Misses      40302    40398      +96     
  Partials       17       17              
Impacted Files Coverage Δ
...s/atoms/Plugin/PluginIFrame/usePostMessage.test.ts 100.00% <ø> (ø)
...onents/atoms/Plugin/PluginIFrame/usePostMessage.ts 92.10% <ø> (ø)
...rc/components/molecules/Visualizer/Plugin/hooks.ts 5.57% <3.84%> (-0.36%) ⬇️
src/components/atoms/Plugin/index.tsx 31.89% <18.46%> (-10.46%) ⬇️
src/components/atoms/Plugin/PluginIFrame/index.tsx 37.03% <37.03%> (ø)
src/components/atoms/Plugin/PluginIFrame/hooks.ts 100.00% <100.00%> (ø)
.../components/atoms/Plugin/PluginIFrame/useIFrame.ts 100.00% <100.00%> (ø)
src/components/atoms/Plugin/hooks.ts 95.41% <100.00%> (ø)
...c/components/molecules/Visualizer/Plugin/index.tsx 100.00% <100.00%> (ø)

@rot1024 rot1024 merged commit fc5f58e into main Aug 31, 2022
@rot1024 rot1024 deleted the modal2 branch August 31, 2022 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant