Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: fix the camera offset when keep press on zoom to layer #335

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 25, 2022

Overview

when keep pressing on zoom to layer the offset is keep changing , so this pr is to fix that

What I've done

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit 8cd3d38
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/635a4fdd44803000093f5a47

@nina992 nina992 marked this pull request as ready for review October 25, 2022 08:44
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #335 (8cd3d38) into main (3af5206) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   18.12%   18.12%   -0.01%     
==========================================
  Files         512      512              
  Lines       50916    50921       +5     
  Branches      613      613              
==========================================
  Hits         9228     9228              
- Misses      41668    41673       +5     
  Partials       20       20              
Impacted Files Coverage Δ
...molecules/Visualizer/Engine/Cesium/useEngineRef.ts 68.12% <0.00%> (-1.09%) ⬇️

@nina992 nina992 merged commit ccec332 into main Oct 27, 2022
@nina992 nina992 deleted the fix-zoomOffset branch October 27, 2022 09:44
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants