This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: extend plugin API supports get viewport's size #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 18.12% 18.09% -0.03%
==========================================
Files 512 512
Lines 50945 51054 +109
Branches 619 619
==========================================
+ Hits 9232 9237 +5
- Misses 41692 41796 +104
Partials 21 21
|
rot1024
suggested changes
Oct 31, 2022
rot1024
reviewed
Nov 2, 2022
rot1024
suggested changes
Nov 4, 2022
rot1024
approved these changes
Nov 4, 2022
src/components/molecules/Visualizer/WidgetAlignSystem/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Nov 8, 2022
KaWaite
approved these changes
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reearth/reearth-visualizer#363
Overview
Enable plugin get the size of reearth viewport.
Enable plugin add an event listener on viewport's resize event.
Note:
isMobile
===width
<= 768What I've done
Implement plugin APIs:
Also pass the
isMobile
as a prop to WAS.What I haven't done
How I tested
Tested with browsers:
Tested in browser devtool console.
Tested with plugin:
Screenshot
Which point I want you to review particularly
Memo