Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: extend plugin API supports get scene inEditor #351

Merged
merged 9 commits into from
Nov 16, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Nov 9, 2022

Overview

Plugin needs to know whether it's running with the earth editor.

For pages:
earth editor => true
preview => false
published => false
plugin editor => false for now. We can also update plugin editor's UI to support switch value if needed in the future.

What I've done

Implement plugin API

reearth.scene.inEditor: boolean

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit bddad7e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6374427645ccb30008ce72cd
😎 Deploy Preview https://deploy-preview-351--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #351 (bddad7e) into main (af55f1a) will decrease coverage by 0.00%.
The diff coverage is 4.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   18.38%   18.37%   -0.01%     
==========================================
  Files         514      514              
  Lines       51602    51622      +20     
  Branches      640      640              
==========================================
+ Hits         9485     9486       +1     
- Misses      42082    42101      +19     
  Partials       35       35              
Impacted Files Coverage Δ
src/components/molecules/Visualizer/Plugin/api.ts 6.44% <0.00%> (-0.08%) ⬇️
...rc/components/molecules/Visualizer/Plugin/types.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/hooks.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/index.tsx 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/storybook.tsx 0.00% <0.00%> (ø)
...ponents/organisms/EarthEditor/CanvasArea/index.tsx 0.00% <0.00%> (ø)
src/components/pages/EarthEditor/index.tsx 0.00% <0.00%> (ø)
...components/molecules/Visualizer/Plugin/context.tsx 30.38% <20.00%> (-0.16%) ⬇️

@airslice airslice changed the title feat: extend plugin API get scene public feat: extend plugin API get scene inEditor Nov 11, 2022
@airslice airslice changed the title feat: extend plugin API get scene inEditor feat: extend plugin API supports get scene inEditor Nov 11, 2022
@airslice airslice marked this pull request as ready for review November 11, 2022 04:25
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unify all isInEditor to inEditor

src/components/molecules/Visualizer/Plugin/api.ts Outdated Show resolved Hide resolved
@airslice airslice merged commit ec0b81d into main Nov 16, 2022
@airslice airslice deleted the feat/plugin-api-scene-public branch November 16, 2022 02:00
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants