This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiya01
force-pushed
the
feature/box-api-interaction
branch
from
November 15, 2022 11:30
73924bc
to
c2abaa0
Compare
keiya01
force-pushed
the
feature/box-api-interaction
branch
from
November 15, 2022 11:33
c2abaa0
to
bfbe7bd
Compare
keiya01
force-pushed
the
feature/box-api-interaction
branch
from
November 15, 2022 12:50
7e6576c
to
bb0c0d8
Compare
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I did refactor to move hooks to hooks file in refactor: separate component logic to hooks |
keiya01
force-pushed
the
feature/box-api-interaction
branch
from
November 21, 2022 03:13
5428128
to
630e6df
Compare
@rot1024 |
@rot1024 |
@KaWaite |
KaWaite
approved these changes
Nov 29, 2022
rot1024
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added some layer to the Box layer. These layer is used to handle some interaction like the following.
What I've done
ScalePoint
layerEdge
layerboxscale
event to handle scaling boxboxrotate
event to handle rotating boxWhat I haven't done
How I tested
Screenshot
box-clipping.mp4
Which point I want you to review particularly
Memo