Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: editable box #357

Merged
merged 41 commits into from
Nov 30, 2022
Merged

feat: editable box #357

merged 41 commits into from
Nov 30, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 15, 2022

Overview

I added some layer to the Box layer. These layer is used to handle some interaction like the following.

  • Scaling the box
  • Rotating the box

What I've done

  • added ScalePoint layer
  • added Edge layer
  • added boxscale event to handle scaling box
  • added boxrotate event to handle rotating box

What I haven't done

How I tested

  1. Install the clipping-box-plugin
  2. And set position, tileset url, box color in the widget panel.
  3. Move the Box horizontally or vertically.

Screenshot

box-clipping.mp4

Which point I want you to review particularly

Memo

@keiya01 keiya01 changed the title Feature/box api interaction Feat: add box api interaction Nov 15, 2022
@keiya01 keiya01 changed the title Feat: add box api interaction feat: add box api interaction Nov 15, 2022
@rot1024 rot1024 changed the title feat editable box feat: editable box Nov 17, 2022
@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit d61d8f3
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6386a50779f1250008f36be6
😎 Deploy Preview https://deploy-preview-357--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keiya01
Copy link
Member Author

keiya01 commented Nov 21, 2022

I did refactor to move hooks to hooks file in refactor: separate component logic to hooks

@keiya01
Copy link
Member Author

keiya01 commented Nov 23, 2022

@rot1024
I fixed the box event to use layeredit event. fix: use layeredit event to scale and rotate box

@keiya01
Copy link
Member Author

keiya01 commented Nov 24, 2022

@rot1024
rotation is renamed to rotate in fix: rename rotation to rotate

@keiya01
Copy link
Member Author

keiya01 commented Nov 26, 2022

@KaWaite
I have done refactor to commonize some logic in refactor: use sampleTerrainHeightFromCartesian

@keiya01 keiya01 enabled auto-merge (squash) November 30, 2022 00:34
@keiya01 keiya01 merged commit 92a159e into main Nov 30, 2022
@keiya01 keiya01 deleted the feature/box-api-interaction branch November 30, 2022 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants